Bump AA, Nemo, and Hecke compat #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/dep-bump
branch
from
76e2554
to
7c48143
Compare
This comment was marked as resolved.
This comment was marked as resolved.
fingolfin
approved these changes
Sep 19, 2024
|
The changes in straight line programs lead to test failures. Haven't yet tried to understand why, need sleep |
lgoettgens
force-pushed
the
lg/dep-bump
branch
from
2811d17
to
f8d5718
Compare
joschmitt
reviewed
Sep 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4122 +/- ##
==========================================
- Coverage 84.67% 84.67% -0.01%
==========================================
Files 626 626
Lines 84265 84249 -16
==========================================
- Hits 71353 71334 -19
- Misses 12912 12915 +3
|
lgoettgens
commented
Sep 20, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 30, 2024
* Bump AA, Nemo, and Hecke compat * Adapt to `addeq!` deprecation and remove some now unnecessary mutable arith methods * Adapt to `@attr` changes * `prime_field` -> `absolute_base_field` for padics * Assertions.jl moved to AA --------- Co-authored-by: Johannes Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still waiting for a Hecke release.